search

MycroftAI / hardware-mycroft-mark-II

Mycroft's Mark II Rpi mechanical, electrical and industrial designs
107 stars 32 forks source link

'Enclosure skill" won't stop ona " mycroft-start restart all " command #48

Open Olzeke51 opened 3 years ago

Olzeke51 commented 3 years ago

Describe the bug When I issue a " mycroft-start restart all " command , status screen (ssh-terminal) shows 'enclosure not stopping' - - it has to be killed

To Reproduce Steps to reproduce the behavior:

  1. ssh into Mycroft unit
  2. Type "" mycroft-start restart all " command
  3. see results in ssh-terminal screen
  4. See error '....'

Expected behavior a stopped enclosure - not a kill

Log files

olzeke51@Tester:~$ ssh -p 8222 mycroft@192.168.2.4
(.venv) mycroft@localhost:~$ mycroft-start restart all
Starting all mycroft-core services
Initializing...
Restarting: bus
Stopping messagebus.service (258)...stopped.
CAUTION: The Mycroft bus is an open websocket with no built-in security
         measures.  You are responsible for protecting the local port
         8181 with a firewall as appropriate.
Restarting: skills
Stopping skills (265)...stopped.
Restarting: audio
Stopping audio (274)...stopped.
Restarting: voice
Stopping speech (278)...stopped.
Restarting: enclosure
Stopping enclosure (283)...failed to stop.
  Killing enclosure (283)...killed.

Environment

Additional context - just an observation seems odd that you would 'start' service then stop them ; after they already a started also I would have thought the message_bus would be the last to shutdown

krisgesling commented 3 years ago

Thanks for reporting this, it shouldn't cause issues but it could and it shouldn't be happening so definitely something we want to fix up but it's going to be lower priority at the moment.