search

MycroftAI / lingua-franca

Mycroft's multilingual text parsing and formatting library
Apache License 2.0
75 stars 78 forks source link

Polish language - initial support #107

Open rafaljanicki opened 4 years ago

rafaljanicki commented 4 years ago

Code: pl-pl

This is a work in progress which I've started last week and plan to deliver this week. I've created this issue as a placeholder in order to notify other potential users that such translation is underway. I'll update this ticket once the PR is ready.

krisgesling commented 4 years ago

That's excellent, thanks Rafal!

rafaljanicki commented 4 years ago

Hey @ChanceNCounter , just wanted to reply here on the comment in #114 as it'd be offtopic otherwise. I tried to follow the regular approach and kind of based on what was done in the Czech language, so I believe we're quite good here. I can merge the languages refactor branch to that one if that'd be helpful for you :)

rafaljanicki commented 4 years ago

Hey @ChanceNCounter , did we move anywhere with it? I did spend a lot of private time on adding the support with a hope of integrating it into Mycroft

ChanceNCounter commented 4 years ago

Terrible apologies. I've been neglecting FOSS for most of 3 months, without warning. Potentially-paid projects swallowed me whole, and I haven't been at a Linux box for more than a few minutes since!

I'm setting aside a few hours this afternoon to catch up on PRs and code reviews. The current time is 1940-something. I'm on the West Coast of NA, so figure midnight UTC, give or take.

Really, sincerely sorry.

rafaljanicki commented 4 years ago

Thanks @ChanceNCounter , appreciate that! And I fully understand your situation, I'm a freelancer myself :-)

ChanceNCounter commented 4 years ago

Just occurred to me that you might not be watching that other PR. I've pushed answers to the most recent round of review on the refactor (say that five times fast.) Once it gets another glance from other collaborators, and I finish adding unit tests to the new functions, I think it'll be about done, and we can resume slotting new languages.

If you'd like to try it out, and let me know how it feels from the perspective of a programmer localizing our existing functions, I'll certainly take any feedback on board. If not, no worries! I believe these functions will become drop-ins rather soon, and we'll drop them in.