Closed Willem3141 closed 4 years ago
Hi, I just tested this and it works nicely with your fix. Thank you for providing it.
Before merging we require you to sign the Contributor License Agreement to ensure that you retain the rights to your submission while granting Mycroft right to use it.
@forslund Signing a CLA seems overkill for such a trivial change. I hereby release my contribution under CC0 (public domain). If that is not sufficient, I don't mind if you close this MR, and remove the line installing yarn independently :slightly_smiling_face:
I understand @Willem3141, it's sort of a line drawing thing, if we allow this then we could allow this little bigger change...so we require it on everything. I'll talk it over with the others and if not OK I'll recreate your PR as you suggested.
In any case huge thanks for flagging and providing a solution.
Thanks for this @Willem3141, We talked it over and I ended up recreating the PR (#25). Thanks for providing the solution.
It seems that the
node:latest
image already includes yarn, which causes an error message when trying to build the container:This causes the build to fail. Removing the yarn installation entirely fixes this issue.