search

MycroftAI / mimic-recording-studio

Mimic Recording Studio is a Docker-based application you can install to record voice samples, which can then be trained into a TTS voice with Mimic2
Apache License 2.0
499 stars 116 forks source link

remove the horizontal scroll bar #90

Closed ibnsultan closed 3 months ago

ibnsultan commented 1 year ago

Comment

Remove the horizontal scroll bar that distorts the view of small screens during the sound preview

krisgesling commented 1 year ago

Hi there, thanks for signing our CLA - you've been added to our list of excellent humans!

About this PR, I wanted to check - is there actually content that requires you to horizontally scroll on your sized screen or is the horizontal bar just showing?

If there is content off to the side, we probably need to look at how we improve the interface for screen sizes that have this behaviour.

ibnsultan commented 1 year ago

The sound wave preview kind of overflows to the left on the small screen. chrome: v107

krisgesling commented 1 year ago

Yeah right, my concern then is that if we remove the scrollbar, do we remove the ability to reach anything?

I'm not running this at all atm so hard for me to see exactly how it behaves.

If the audio preview content scrolls across as it plays and all navigation remains accessible, then that seems fine. But if primary navigation items become inaccessible then we clearly have a problem.