search

MycroftAI / mimic2

Text to Speech engine based on the Tacotron architecture, initially implemented by Keith Ito.
Apache License 2.0
581 stars 103 forks source link

Upgrade to Tensorflow V 2.x? #43

Open v2thegreat opened 4 years ago

v2thegreat commented 4 years ago

Hey, seeing as there's a new version out for TensorFlow, and there is a tool for upgrading from TF 1.x to 2.x

Is this something that can be done for this project? Especially seeing as the current version of TF that this project has been tested on is still running on 1.8, which is not even available on the latest version of Python 3.7 (due to being deprecated I think)

el-tocino commented 4 years ago

I think you'd have to DIY and submit a PR. The head repo also is currently incompatible: https://github.com/keithito/tacotron/issues/309 Mimic2 seems to be pretty low on the priority list for the mycroft team right now.

v2thegreat commented 4 years ago

Hmm, isn't that the point of the upgrade tool. I'll run the tool and make sure all the tests pass. If it's not too much of a hassle to fix whatever issues come up next, I'll make a new PR

PureTryOut commented 3 years ago

Hey @v2thegreat did you have any luck with this?

v2thegreat commented 3 years ago

I'm sorry to say that I haven't had the time to explore this. Been busy with Uni and work and some other projects. Actually, I wasn't able to get this working too far in the first place. I might try to get back into getting mimic2 working and then porting over to V2, but no guarantees for now since I'm not very familiar with TensorFlow yet.

If someone more experienced than me wants to take a crack at it, go ahead

catfishjw commented 2 years ago

after running the fixing tool on the entire file, I can confirm that this does not work. While much of the project can use Tensorflow's built in compadability features, the project is too dependent on tf.contrib, which was entirely removed in Tensorflow 2.X. The only way for it to work would be to go in and replace all instances of tf.contrib with their supported functions. Im giving it a shot, but at the end of the day I'm not proficient enough at Tensorflow to fix the various issues this introduces. If I do eventually figure it out, I will post results here.

el-tocino commented 2 years ago

I'd skip working on this and go contribute to https://github.com/coqui-ai/TTS/ instead, which is already leaps ahead and actively being worked on.