search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.52k stars 1.27k forks source link

The code doesn't pass the flakes static checks #18

Closed come-maiz closed 8 years ago

come-maiz commented 8 years ago

⟫ pyflakes . ./mycroft/client/text/cli.py:44: local variable 'e' is assigned to but never used ./mycroft/client/speech/listener.py:350: local variable 'e' is assigned to but never used ./mycroft/client/speech/main.py:90: local variable 'e' is assigned to but never used ./mycroft/client/speech/wakeword_recognizer.py:5: 'sys' imported but unused ./mycroft/client/speech/wakeword_recognizer.py:7: 'from pocketsphinx import *' used; unable to detect undefined names ./mycroft/client/speech/wakeword_recognizer.py:46: Decoder may be undefined, or defined from star imports: pocketsphinx ./mycroft/client/speech/wakeword_recognizer.py:56: Decoder may be undefined, or defined from star imports: pocketsphinx ./mycroft/util/setup_base.py:19: local variable 'e' is assigned to but never used ./mycroft/util/setup_base.py:22: local variable 'e2' is assigned to but never used ./mycroft/messagebus/service/ws.py:36: local variable 'e' is assigned to but never used ./mycroft/messagebus/service/main.py:2: 'tornado' imported but unused ./mycroft/skills/intent/init.py:27: local variable 'e' is assigned to but never used ./mycroft/skills/wolfram_alpha/init.py:106: local variable 'e' is assigned to but never used ./mycroft/skills/weather/owm_repackaged/init.py:14: 'timeutils' imported but unused ./mycroft/skills/weather/owm_repackaged/owmhttpclient.py:69: 'urlopen' imported but unused ./mycroft/pairing/client.py:1: 'json' imported but unused ./mycroft/pairing/client.py:4: 'sys' imported but unused ./test/skills/skill_tester.py:2: 'unittest' imported but unused

ikeydoherty commented 8 years ago

@elopio i would argue this is a duplicate of (or candidate for merge with) #4

ikeydoherty commented 8 years ago

@elopio also see #2 where I iterated these issues that you've raised.

MatthewScholefield commented 8 years ago

@ikeydoherty I could be wrong but it seems like autopep8 only deals with formatting whereas pyflakes deals with unused variables and imports.

ryanleesipes commented 8 years ago

If someone would be so kind as to volunteer to focus in on these, that would be awesome.

aatchison commented 8 years ago

I started to knock out some I think. It's mostly just getting rid of unused imports and such. Should be fairly easy. We need to integrate the license headers asap though because everyone will have to rebase. On May 23, 2016 6:34 PM, "Ryan Sipes" notifications@github.com wrote:

If someone would be so kind as to volunteer to focus in on these, that would be awesome.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/MycroftAI/mycroft-core/issues/18#issuecomment-221126515

ryanleesipes commented 8 years ago

Erroneously closed this, time to get to fixing!

ryanleesipes commented 8 years ago

PR #60 addresses this.