search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.51k stars 1.27k forks source link

update responsive voice TTS #2434

Closed JarbasAl closed 2 years ago

JarbasAl commented 4 years ago

integration of responsive voice uses an older version of my package https://github.com/OpenJarbas/py_responsivevoice

we should either pin an older version of the package/log a warning, or update the TTS engine to support all the new voices

forslund commented 4 years ago

Maybe we should do both? update it to the current version adding the new voices and pin that?

JarbasAl commented 4 years ago

i will look into adding some extra logic in my package to lookup a voice by a named string, this should make it easier to integrate

regarding pinning versions, since this is not a default requirement how would we do that? in the TTS Validator class?

Edit: i think i can implement this in a way that is backwards compatible with all package versions, code won't be as clean but should just work and avoid the need for version pinning

JarbasAl commented 2 years ago

i don't think this issue was ever fixed and responsive voice changed quite a bit since

i am closing this since engines are being migrated into plugins and one already exists https://github.com/OpenVoiceOS/ovos-tts-plugin-responsivevoice