Make TTSCache safer - Githubissues

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.

https://mycroft.ai

Apache License 2.0

6.52k stars 1.27k forks source link

Make TTSCache safer #2914

Closed forslund closed 3 years ago

forslund commented 3 years ago

Description

Add __contains__ method to TTSCache, The cache contains a SHA if the SHA is known and all expected files exists on disk.

This is handles unexpected system events in a more consistent manner and will still be fast for the case where a new sentence needs to be synthesized.

How to test

Ask Mycroft to "say hello"
remove all files in /tmp/mycroft/cache/Mimic2/ (or the TTS you're using)
ask Mycroft to "say hello" again
verify that an audio is produced

Contributor license agreement signed?

CLA [ yes ]

devops-mycroft commented 3 years ago

Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

devops-mycroft commented 3 years ago

Voight Kampff Integration Test Succeeded (Results)

forslund commented 3 years ago

One can always create more tests :) I'll try to add some

forslund commented 3 years ago

A couple of tests has been added!

devops-mycroft commented 3 years ago

Voight Kampff Integration Test Succeeded (Results)

forslund commented 3 years ago

Thanks for noticing that mistake, Added the "gobo" check and corrected the logic snafu

devops-mycroft commented 3 years ago

Voight Kampff Integration Test Succeeded (Results)