forslund commented 3 years ago

Description

Fixes issues with retuned file as reported and suggested by @JarbasAI

Ensures that the returned file from get_tts() is a Path object and fixes the comparisons. This means that a get_tts can also return a Path object instead of a str and all should be well,

How to test

Run branch ensure that audio is heard and the lookups works.

Contributor license agreement signed?

CLA [ Yes ]

codecov-commenter commented 3 years ago

Codecov Report

Merging #2938 (0ae02b5) into dev (6099da1) will decrease coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #2938      +/-   ##
==========================================
- Coverage   52.69%   52.64%   -0.06%     
==========================================
  Files         123      123              
  Lines       11021    11023       +2     
==========================================
- Hits         5808     5803       -5     
- Misses       5213     5220       +7

Impacted Files	Coverage Δ
mycroft/tts/tts.py	`79.60% <100.00%> (+0.13%)`	:arrow_up:
mycroft/client/speech/hotword_factory.py	`70.52% <0.00%> (-2.11%)`	:arrow_down:
mycroft/client/speech/listener.py	`48.04% <0.00%> (-0.36%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6099da1...0ae02b5. Read the comment docs.

devops-mycroft commented 3 years ago

Voight Kampff Integration Test Succeeded (Results)