search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.51k stars 1.27k forks source link

Use unique paths for temp file storage #2944

Closed krisgesling closed 3 years ago

krisgesling commented 3 years ago

Description

When transferring the Allure report and the Mycroft logs to the report host, the zip files were being written to a common directory. In the event that multiple jobs were writing to or reading from this directory at the same time, conflicts could occur.

This ensures that both zip files are written to unique paths and cleaned up afterward.

Companion PR to https://github.com/MycroftAI/mycroft-skills/pull/1516

How to test

CI should pass - then verify that both the Allure report and the mycroft-logs are accessible using the links in the comment. Should also replay it on some other PR's using this modified Jenkins file, particularly ones that expected to fail.

Contributor license agreement signed?

devops-mycroft commented 3 years ago

Voight Kampff Integration Test Succeeded (Results)

codecov-commenter commented 3 years ago

Codecov Report

Merging #2944 (d14e6b6) into dev (80f9eb0) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2944   +/-   ##
=======================================
  Coverage   52.64%   52.64%           
=======================================
  Files         123      123           
  Lines       11021    11021           
=======================================
  Hits         5802     5802           
  Misses       5219     5219

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 80f9eb0...d14e6b6. Read the comment docs.