search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.51k stars 1.27k forks source link

VK event based then wait #2949

Closed forslund closed 3 years ago

forslund commented 3 years ago

Description

A restructure on how waiting for events work in VK based on comments from Chris.

This removes the handling of every single event and insteads sets up a temporary event handler handling the capture of events.

A check of the captured messages are also made to avoid certain race conditions.

I do think the naming and some of the logic needs to pass through a brain (at least) one more time.

How to test

See if the VK tests passes.

Contributor license agreement signed?

CLA [ Yes ]

devops-mycroft commented 3 years ago

Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

forslund commented 3 years ago

Closing and re-opening due to VK file permission issues.