Description:
When registering entities with Adapt we use start_concept, end_concept whilst Adapt uses entity_value, entity_type. Start and End don't really reflect what the arguments are (if I understand them correctly). So I'm recommending that we rename them throughout the code base. Docstrings should also be added or updated as needed.
Description: When registering entities with Adapt we use
start_concept, end_conceptwhilst Adapt usesentity_value, entity_type. Start and End don't really reflect what the arguments are (if I understand them correctly). So I'm recommending that we rename them throughout the code base. Docstrings should also be added or updated as needed.Additional context Originally raised in this PR https://github.com/MycroftAI/mycroft-core/pull/2877#pullrequestreview-670931419