Update key names in adapt keyword registration message

[forslund]

Description

This should resolve #2950. It matches the keyword entity terms in Mycroft with the ones used in Adapt.

This changes the internally used names for entities and entity values when sent on the messagebus and used internally in the intent service from start / end to entity_value and entity_type.

This makes the terminology easier to understand and follow across into Adapt.

The old terms are still included and usable for compatibility but should be removed in an upcoming major release (22.02).

How to test

Ensure VK tests works.

Contributor license agreement signed?

CLA [ Yes ]

[devops-mycroft]

Voight Kampff Integration Test Succeeded (Results)

[forslund]

I'm doing some work on a skill implementation in rust and used the updated names here but realized it hasn't been reviewed. Should I revert back to the current names or is this something that could be included down the line?

[codecov-commenter]

Codecov Report

Merging #2963 (f709bb9) into dev (3c76177) will increase coverage by 0.22%. The diff coverage is 95.23%.

@@            Coverage Diff             @@
##              dev    #2963      +/-   ##
==========================================
+ Coverage   52.80%   53.02%   +0.22%     
==========================================
  Files         123      123              
  Lines       11106    11156      +50     
==========================================
+ Hits         5865     5916      +51     
+ Misses       5241     5240       -1     

Impacted Files	Coverage Δ
mycroft/skills/intent_services/adapt_service.py	80.28% <50.00%> (-0.44%)	:arrow_down:
mycroft/skills/intent_service.py	68.85% <100.00%> (+1.13%)	:arrow_up:
mycroft/skills/intent_service_interface.py	35.38% <100.00%> (+1.35%)	:arrow_up:
mycroft/skills/mycroft_skill/mycroft_skill.py	74.73% <100.00%> (+0.04%)	:arrow_up:
mycroft/skills/common_query_skill.py	93.61% <0.00%> (+7.17%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c76177...f709bb9. Read the comment docs.