MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.51k stars 1.27k forks source link

scripts: Support busybox chown #2966

Closed rzr closed 3 years ago

rzr commented 3 years ago

Those extra options are not enabled in busybox (at least not the configured version in poky yocto distribution)

This will also help to support systems without coreutils,

Relate-to: https://github.com/MycroftAI/mycroft-core/pull/2686 Signed-off-by: Philippe Coval philippe.coval@astrolabe.coop

Description

(Description of what the PR does, such as fixes # {issue number})

How to test

(Description of how to validate or test this PR)

Contributor license agreement signed?

CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement

devops-mycroft commented 3 years ago

Hello, @rzr, thank you for helping with the Mycroft project! We welcome everyone into the community and greatly appreciate your help as we work to build an AI for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require a Contributor Licensing Agreement (CLA) before accepting any code contribution. This agreement makes it crystal clear that along with your code you are offering a license to use it within the confines of this project. You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank you!

devops-mycroft commented 3 years ago

Voight Kampff Integration Test Succeeded (Results)

krisgesling commented 3 years ago

Hi @rzr - thanks for signing the CLA - you've been added to our list of excellent humans

If I don't hear any objections I can't see any reason to keep these flags if they're blocking support for a system.

For reference they are:

       -f, --silent, --quiet
              suppress most error messages

       -v, --verbose
              output a diagnostic for every file processed
forslund commented 3 years ago

The v and f seems quite redundant...verbose and quiet...

The default (without -v) is quiet and will only report errors so I too think this is a good change