search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.51k stars 1.27k forks source link

Voight Kampff: No skill updates at runtime #2968

Closed forslund closed 3 years ago

forslund commented 3 years ago

Description

A lot of the skill logs are covered in msm update messages, the updates should generally not make any changes in VK and can't be verified so they are superfluous.

How to test

Ensure there are no msm update logs in the VK output.

Contributor license agreement signed?

CLA [ Yes ]

devops-mycroft commented 3 years ago

Voight Kampff Integration Test Succeeded (Results)

krisgesling commented 3 years ago

Am I right in thinking that this would only affect updating of Skills during the lifetime of a single test run since the container is built each time which includes installing all the default Skills?

Sounds like a good move to me.

forslund commented 3 years ago

You are correct. The VK startup updates and installs the default skills, during runtime the skills (in my opinion) should not be updated since it adds no value and can potentially do some weird things like change the behavior of the skill after the feature file has been copied by VK causing a mismatch between expected behavior and actual behavior.