search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.51k stars 1.27k forks source link

Release GUI on Skill shutdown or reload #2979

Closed krisgesling closed 2 years ago

krisgesling commented 3 years ago

Description

When a Skill shuts down, the GUI data is cleared but not released. This removes the Skill reference on shutdown.

Contributor license agreement signed?

codecov-commenter commented 3 years ago

Codecov Report

Merging #2979 (6cdecdc) into dev (61cbaa7) will decrease coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head 6cdecdc differs from pull request most recent head d26201d. Consider uploading reports for the commit d26201d to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2979      +/-   ##
==========================================
- Coverage   52.80%   52.80%   -0.01%     
==========================================
  Files         123      123              
  Lines       11104    11104              
==========================================
- Hits         5864     5863       -1     
- Misses       5240     5241       +1
Impacted Files Coverage Δ
mycroft/enclosure/gui.py 85.36% <100.00%> (ø)
mycroft/client/speech/listener.py 48.04% <0.00%> (-0.36%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61cbaa7...d26201d. Read the comment docs.

devops-mycroft commented 3 years ago

Voight Kampff Integration Test Succeeded (Results)