search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.51k stars 1.27k forks source link

Fix messages clearing in the InterceptAllBusClient #2990

Closed chrisveilleux closed 2 years ago

chrisveilleux commented 3 years ago

Description

The logic that is intended to clear processed messages was clearing messages that have not yet been read, not messages that have already been read.

How to test

Run a test that uses the clear_messages function in the InterceptAllBusClient.

Contributor license agreement signed?

CLA [X] (Whether you have signed a CLA - Contributor Licensing Agreement

codecov-commenter commented 3 years ago

Codecov Report

Merging #2990 (4c63ac1) into dev (13539d3) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 4c63ac1 differs from pull request most recent head df94e21. Consider uploading reports for the commit df94e21 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2990   +/-   ##
=======================================
  Coverage   52.80%   52.80%           
=======================================
  Files         123      123           
  Lines       11104    11104           
=======================================
  Hits         5864     5864           
  Misses       5240     5240

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13539d3...df94e21. Read the comment docs.

forslund commented 3 years ago

Doh, such a dumb mistake.

devops-mycroft commented 3 years ago

Voight Kampff Integration Test Succeeded (Results)

forslund commented 3 years ago

I created the PR https://github.com/MycroftAI/skill-volume/pull/82 which makes the volume increase / decrease checks more standardized and working both with and without this fix.