search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.51k stars 1.27k forks source link

Fix pulseaudio daemon failing to start in CI #2992

Closed krisgesling closed 2 years ago

krisgesling commented 3 years ago

Description

This fixes an issue in the CI runs of Voight Kampff where the pulseaudio daemon would fail on load.

This failure would result in the Volume Skill always failing it's tests.

This change has been manually applied to the 21.2.1 VK Docker image to enable: https://github.com/MycroftAI/mycroft-skills/pull/1566

Fixes: https://github.com/MycroftAI/mycroft-skills/issues/1560

How to test

See the build history of Mycroft-Skill PR-1566. It was consistently failing to start the pulse daemon. The failure can be found very close to the top of the docker run step, eg here

Fix has been applied to the latest run. The checks on this PR should also pass.

Contributor license agreement signed?

codecov-commenter commented 3 years ago

Codecov Report

Merging #2992 (4e366b4) into dev (13539d3) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 4e366b4 differs from pull request most recent head 59c473c. Consider uploading reports for the commit 59c473c to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #2992   +/-   ##
=======================================
  Coverage   52.80%   52.80%           
=======================================
  Files         123      123           
  Lines       11104    11104           
=======================================
  Hits         5864     5864           
  Misses       5240     5240

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13539d3...59c473c. Read the comment docs.

devops-mycroft commented 3 years ago

Voight Kampff Integration Test Succeeded (Results)