search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.51k stars 1.27k forks source link

Patch dependencies that use the deprecated use_2to3 #2996

Closed krisgesling closed 2 years ago

krisgesling commented 2 years ago

Description

Setuptools deprecated use of use_2to3 from v58 (see changelog)

This is still included in the behave and cucumber-tag-expressions packages. The problem has been reported upstream to both packages. The simplest short term fix while waiting for upstream seems to be using forked versions and removing Python2 support. It's more difficult to pin setuptools as this is installed via system packages in dev_setup.sh

The reason this is a problem, is that the pip install of behave and cucumber-tag-expressions are currently failing when using the pip git install method in Github Actions. See: https://github.com/MycroftAI/mycroft-core/runs/3530814664?check_suite_focus=true#step:7:407

This change means these two packages will instead be installed from a patched fork of each package. These could be moved into the Mycroft org, but I expect them to be temporary patches until upstream releases a new version.

Alternatively we could enforce a specific version of setuptools < v58.

How to test

Run dev_setup.sh and ensure it installs cleanly. Run unit and VK tests to ensure they succeed.

Contributor license agreement signed?

devops-mycroft commented 2 years ago

Voight Kampff Integration Test Succeeded (Results)

codecov-commenter commented 2 years ago

Codecov Report

Merging #2996 (539ed9c) into dev (170ebc4) will decrease coverage by 0.03%. The diff coverage is 62.26%.

:exclamation: Current head 539ed9c differs from pull request most recent head 50b02f8. Consider uploading reports for the commit 50b02f8 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2996      +/-   ##
==========================================
- Coverage   52.85%   52.81%   -0.04%     
==========================================
  Files         123      123              
  Lines       11044    11105      +61     
==========================================
+ Hits         5837     5865      +28     
- Misses       5207     5240      +33
Impacted Files Coverage Δ
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/__init__.py 0.00% <0.00%> (ø)
mycroft/client/text/text_client.py 0.00% <0.00%> (ø)
mycroft/messagebus/send_func.py 38.46% <0.00%> (-4.40%) :arrow_down:
mycroft/filesystem/__init__.py 80.00% <62.50%> (-8.89%) :arrow_down:
mycroft/api/__init__.py 80.76% <66.66%> (-0.09%) :arrow_down:
mycroft/client/speech/hotword_factory.py 70.70% <81.25%> (+0.18%) :arrow_up:
mycroft/util/file_utils.py 94.05% <83.33%> (-0.74%) :arrow_down:
mycroft/skills/event_scheduler.py 68.50% <85.71%> (+0.29%) :arrow_up:
mycroft/configuration/config.py 72.29% <87.50%> (-1.39%) :arrow_down:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4bce534...50b02f8. Read the comment docs.