MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.51k stars 1.27k forks source link

dev_setup.sh incorrectly excludes certain ARM cpu's for avx query. #2999

Closed el-tocino closed 2 years ago

el-tocino commented 2 years ago

Describe the bug dev_setup.sh incorrectly excludes certain ARM cpu's for avx query. https://github.com/MycroftAI/mycroft-core/blob/9e9f2f74e551efebacf1bd26fc3ed7fde35fae48/dev_setup.sh#L179

To Reproduce Steps to reproduce the behavior:

  1. Run dev_setup.sh on an aarch64 platform

Expected behavior avx query would recognize this is an arm platform and move on.

Log files

pi@raspberrypi:~/mycroft-core $ bash dev_setup.sh

                    Welcome to Mycroft!  

This script is designed to make working with Mycroft easy.  During this
first run of dev_setup we will ask you a few questions to help setup
your environment.

The Precise Wake Word Engine requires the AVX instruction set, which is
not supported on your CPU. Do you want to fall back to the PocketSphinx
engine? Advanced users can build the precise engine with an older
version of TensorFlow (v1.13) if desired and change use_precise to true
in mycroft.conf.
  Y)es, I want to use the PocketSphinx engine or my own.
  N)o, stop the installation.
Choice [Y/N]:  N - quit the installation 
pi@raspberrypi:~/mycroft-core $ cat /proc/cpuinfo 
processor       : 0
BogoMIPS        : 108.00
Features        : fp asimd evtstrm crc32 cpuid
CPU implementer : 0x41
CPU architecture: 8
CPU variant     : 0x0
CPU part        : 0xd08
CPU revision    : 3

processor       : 1
BogoMIPS        : 108.00
Features        : fp asimd evtstrm crc32 cpuid
CPU implementer : 0x41
CPU architecture: 8
CPU variant     : 0x0
CPU part        : 0xd08
CPU revision    : 3

processor       : 2
BogoMIPS        : 108.00
Features        : fp asimd evtstrm crc32 cpuid
CPU implementer : 0x41
CPU architecture: 8
CPU variant     : 0x0
CPU part        : 0xd08
CPU revision    : 3

processor       : 3
BogoMIPS        : 108.00
Features        : fp asimd evtstrm crc32 cpuid
CPU implementer : 0x41
CPU architecture: 8
CPU variant     : 0x0
CPU part        : 0xd08
CPU revision    : 3

Hardware        : BCM2835
Revision        : b03114
Serial          : 10000000f328eb95
Model           : Raspberry Pi 4 Model B Rev 1.4
pi@raspberrypi:~/mycroft-core $ uname -m
aarch64

Environment (please complete the following information):

el-tocino commented 2 years ago

a change to something like ! [[ $(uname -m) == 'arm'* || $(uname -m) == 'aarch64' ]] seems easiest?