search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.51k stars 1.27k forks source link

Fixed formatting error in skill loader log message #3010

Closed chrisveilleux closed 2 years ago

chrisveilleux commented 2 years ago

Description

There were no curly braces in a log message to mark where the module name should go in the message.

How to test

Restart Mycroft with debug logging turned on. Look for a log message that starts with "Skill module:" the name of the module should appear after the colon

Contributor license agreement signed?

CLA [X] (Whether you have signed a CLA - Contributor Licensing Agreement

codecov-commenter commented 2 years ago

Codecov Report

Merging #3010 (3179299) into dev (df78af1) will not change coverage. The diff coverage is 0.00%.

:exclamation: Current head 3179299 differs from pull request most recent head 5229f61. Consider uploading reports for the commit 5229f61 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3010   +/-   ##
=======================================
  Coverage   53.02%   53.02%           
=======================================
  Files         123      123           
  Lines       11156    11156           
=======================================
  Hits         5916     5916           
  Misses       5240     5240
Impacted Files Coverage Δ
mycroft/skills/skill_loader.py 65.46% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df78af1...5229f61. Read the comment docs.

devops-mycroft commented 2 years ago

Voight Kampff Integration Test Succeeded (Results)

JarbasAl commented 2 years ago

missed opportunity to start using the much more readable f strings :P