MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.

https://mycroft.ai

Apache License 2.0

6.49k stars 1.27k forks source link

Bugfix/issue 3011 #3012

Closed in03 closed 2 years ago

in03 commented 2 years ago

Description

Added a 'do later' flag in place of command that sets use_precise to false if Precise is unavailable, since the command relied on a dependency installed later in the script. After dependencies are installed, if flag is set, run the original update command. Also fixed use_precise wrongly being set to 'true' instead of 'false' after failing the AVX check.

How to test

Run Mycroft dev_setup.sh on an Intel/AMD machine with no AVX support. Installer should complete without jq: command not found error. After install check { "use_precise": false } in /etc/mycroft/mycroft.conf, and not 'true'.

Contributor license agreement signed?

CLA [ ] (Whether you have signed a CLA - Contributor Licensing Agreement

devops-mycroft commented 2 years ago

Hello, @in03, thank you for helping with the Mycroft project! We welcome everyone into the community and greatly appreciate your help as we work to build an AI for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require a Contributor Licensing Agreement (CLA) before accepting any code contribution. This agreement makes it crystal clear that along with your code you are offering a license to use it within the confines of this project. You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank you!

devops-mycroft commented 2 years ago

Voight Kampff Integration Test Succeeded (Results)

codecov-commenter commented 2 years ago

Codecov Report

Merging #3012 (f50b27f) into dev (6daccc4) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #3012   +/-   ##
=======================================
  Coverage   53.02%   53.02%           
=======================================
  Files         123      123           
  Lines       11156    11156           
=======================================
  Hits         5916     5916           
  Misses       5240     5240

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6daccc4...f50b27f. Read the comment docs.

in03 commented 2 years ago

Hey, thanks Kris! I'm a little south of the top in Brisneyland. I haven't contributed to a project as big as Mycroft before, so glad it slots in right 😅

krisgesling commented 2 years ago

It's all north according to the southerners in Sydney/Melbourne :laughing:

You've got far better weather than we do right now though - just had the hottest ever October day in Darwin :ice_cream:

in03 commented 2 years ago

Haha yep! More of them getting out and buying up property here though. Past week, summers storms have come early - decent bit of hail 😬 Gladly take it over the heat though. Stay cool mate!