Closed ChanceNCounter closed 2 years ago
whoa, lots of piggyback commits there. will force-push.
Hello @ChanceNCounter! Thanks for opening this PR. We checked the lines you've touched for PEPÂ 8 issues, and found:
mycroft/audio/services/chromecast/__init__.py
:Line 19:1: E722 do not use bare 'except' Line 166:13: E128 continuation line under-indented for visual indent
mycroft/client/speech/listener.py
:Line 357:17: E265 block comment should start with '# ' Line 361:17: E265 block comment should start with '# '
mycroft/configuration/config.py
:Line 242:20: E111 indentation is not a multiple of four Line 242:20: E117 over-indented
mycroft/configuration/locale.py
:Line 77:9: E722 do not use bare 'except' Line 112:39: W292 no newline at end of file
mycroft/configuration/locations.py
:Line 36:80: E501 line too long (84 > 79 characters) Line 39:80: E501 line too long (89 > 79 characters) Line 62:9: E722 do not use bare 'except'
mycroft/configuration/ovos.py
:Line 15:80: E501 line too long (85 > 79 characters) Line 16:80: E501 line too long (91 > 79 characters) Line 88:5: E722 do not use bare 'except' Line 99:13: E722 do not use bare 'except'
mycroft/enclosure/gui.py
:Line 165:41: E127 continuation line over-indented for visual indent Line 284:41: E127 continuation line over-indented for visual indent
mycroft/filesystem/__init__.py
:Line 42:80: E501 line too long (98 > 79 characters)
mycroft/messagebus/client/__init__.py
:Line 16:52: W292 no newline at end of file
mycroft/messagebus/client/client.py
:Line 27:80: E501 line too long (80 > 79 characters)
mycroft/skills/__main__.py
:Line 63:17: E127 continuation line over-indented for visual indent
mycroft/skills/event_scheduler.py
:Line 75:80: E501 line too long (84 > 79 characters)
mycroft/skills/fallback_skill.py
:Line 140:80: E501 line too long (80 > 79 characters)
mycroft/skills/intent_service.py
:Line 170:80: E501 line too long (84 > 79 characters) Line 171:80: E501 line too long (80 > 79 characters) Line 181:18: E127 continuation line over-indented for visual indent Line 198:80: E501 line too long (82 > 79 characters) Line 204:80: E501 line too long (83 > 79 characters) Line 214:21: E116 unexpected indentation (comment)
mycroft/skills/intent_service_interface.py
:Line 46:80: E501 line too long (82 > 79 characters) Line 65:31: E128 continuation line under-indented for visual indent
mycroft/skills/intent_services/adapt_service.py
:Line 348:80: E501 line too long (80 > 79 characters) Line 358:80: E501 line too long (85 > 79 characters)
mycroft/skills/intent_services/padatious_service.py
:Line 67:80: E501 line too long (81 > 79 characters) Line 129:80: E501 line too long (96 > 79 characters) Line 245:42: E741 ambiguous variable name 'l'
mycroft/skills/msm_wrapper.py
:Line 76:80: E501 line too long (81 > 79 characters) Line 161:9: E722 do not use bare 'except' Line 177:9: E722 do not use bare 'except'
mycroft/skills/mycroft_skill/mycroft_skill.py
:Line 199:80: E501 line too long (82 > 79 characters) Line 200:47: E128 continuation line under-indented for visual indent Line 279:31: E741 ambiguous variable name 'l' Line 280:20: E741 ambiguous variable name 'l' Line 311:27: E127 continuation line over-indented for visual indent Line 493:80: E501 line too long (81 > 79 characters) Line 505:31: E128 continuation line under-indented for visual indent Line 515:31: E128 continuation line under-indented for visual indent Line 633:19: E127 continuation line over-indented for visual indent Line 633:80: E501 line too long (84 > 79 characters) Line 650:15: E127 continuation line over-indented for visual indent Line 949:80: E501 line too long (85 > 79 characters) Line 1497:80: E501 line too long (81 > 79 characters)
mycroft/skills/permissions.py
:Line 22:28: E114 indentation is not a multiple of four (comment) Line 22:28: E116 unexpected indentation (comment) Line 24:30: E114 indentation is not a multiple of four (comment) Line 24:30: E116 unexpected indentation (comment) Line 26:30: E114 indentation is not a multiple of four (comment) Line 26:30: E116 unexpected indentation (comment)
mycroft/skills/settings.py
:Line 92:80: E501 line too long (85 > 79 characters) Line 275:80: E501 line too long (85 > 79 characters) Line 306:80: E501 line too long (83 > 79 characters) Line 361:1: W293 blank line contains whitespace
mycroft/skills/skill_loader.py
:Line 181:29: E261 at least two spaces before inline comment
mycroft/skills/skill_manager.py
:Line 206:20: E128 continuation line under-indented for visual indent Line 389:5: E125 continuation line with same indent as next logical line
mycroft/skills/skill_updater.py
:Line 28:80: E501 line too long (81 > 79 characters) Line 105:80: E501 line too long (88 > 79 characters)
mycroft/tts/mimic2_tts.py
:Line 173:80: E501 line too long (85 > 79 characters)
mycroft/tts/mimic_tts.py
:Line 67:80: E501 line too long (85 > 79 characters)
mycroft/tts/tts.py
:Line 369:21: E722 do not use bare 'except'
mycroft/util/bracket_expansion.py
:Line 71:80: E501 line too long (80 > 79 characters)
mycroft/util/file_utils.py
:Line 66:80: E501 line too long (85 > 79 characters) Line 252:80: E501 line too long (80 > 79 characters)
mycroft/util/log.py
:Line 87:80: E501 line too long (83 > 79 characters)
mycroft/util/parse.py
:Line 164:30: E128 continuation line under-indented for visual indent
mycroft/util/signal.py
:Line 102:5: E722 do not use bare 'except'
heh. sent the replacement of MycroftAI stuff to MycroftAI. do not open PRs via auto hooks. do send bug reports to GitHub.
lest this panic any MycroftAI devs who don't follow OVOS, OVOS-Core is not actually a new fork
it's a take on HolmesV, the Chatterbox core, that isn't owned by a company. this was necessary because some of us can't legally work for other companies without making arrangements with our own employers, so contributing to HelloChatterbox was iffy.
This will probably be easier to review diffs as well :+1:
Oooh, good point!
Updates README
all work and no play makes Jack a dull boy all work and no play makes Jack a dull boy all work and no play makes Jack a dull boy all work and no play makes Jack a dull boyðŸ˜