MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.49k stars 1.27k forks source link

Added Possibility for ESpeak Config #3020

Closed Genei180 closed 2 years ago

Genei180 commented 2 years ago

Description

Fixes my Issue Described in https://github.com/MycroftAI/mycroft-core/issues/3018

The Following Options are available to Set via the Mycroft Config:

Example Config:

{  
  "lang": "de-de",  
  "tts": {  
    "module": "espeak",  
    "espeak": {  
      "lang": "german-mbrola-5",  
      "voice": "german-mbrola-5",  
      "speed": "135",  
      "amplitude": "80",  
      "pitch": "20"  
    }  
  },  
  "max_allowed_core_version": 21.2  
}  

How to test

Install Espeak with the Mbrola Voice after the Mycroft Documentation for Installing German: https://mycroft-ai.gitbook.io/docs/using-mycroft-ai/customizations/languages/german

Contributor license agreement signed?

CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement

Note

Please be extra Careful with my Git Commit History as I tried cleaning it up and I am not sure if I succeeded.

devops-mycroft commented 2 years ago

Hello, @Genei180, thank you for helping with the Mycroft project! We welcome everyone into the community and greatly appreciate your help as we work to build an AI for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require a Contributor Licensing Agreement (CLA) before accepting any code contribution. This agreement makes it crystal clear that along with your code you are offering a license to use it within the confines of this project. You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank you!

devops-mycroft commented 2 years ago

Voight Kampff Integration Test Succeeded (Results)

Genei180 commented 2 years ago

By the way could I please count this Towards my Hacktoberfest Entries? (If it passes) Thank you :)

codecov-commenter commented 2 years ago

Codecov Report

Merging #3020 (b9f0001) into dev (0247b3a) will increase coverage by 0.03%. The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3020      +/-   ##
==========================================
+ Coverage   53.03%   53.07%   +0.03%     
==========================================
  Files         123      123              
  Lines       11170    11187      +17     
==========================================
+ Hits         5924     5937      +13     
- Misses       5246     5250       +4     
Impacted Files Coverage Δ
mycroft/tts/espeak_tts.py 70.27% <72.22%> (+0.27%) :arrow_up:
mycroft/client/speech/listener.py 48.39% <0.00%> (+0.35%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0247b3a...b9f0001. Read the comment docs.

Genei180 commented 2 years ago

About the Plugin, I was kind of Surprised that I could actually find the Code in Mycroft core :)

If I can help with the Plugin, let me know (: But please be aware that it may take some time...

Thanks for your kind feedback!

krisgesling commented 2 years ago

I've also added these options to the documentation: https://mycroft-ai.gitbook.io/docs/using-mycroft-ai/customizations/tts-engine#espeak

Thanks for such a clear PR description :)