search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.49k stars 1.27k forks source link

Check if GUI is connected rather than maintain list of platforms #3025

Closed krisgesling closed 2 years ago

krisgesling commented 2 years ago

Description

There are already many Mycroft platforms that have GUIs and this will only grow. We want to know if the device has a GUI connected rather than if it is in a pre-defined list of platforms.

How to test

With the new latest Wikipedia installed - ask common query a question and ensure it is still displayed.

Contributor license agreement signed?

CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement

devops-mycroft commented 2 years ago

Voight Kampff Integration Test Succeeded (Results)

krisgesling commented 2 years ago

In order to be able to run a scenario that exhibits different behaviour when a GUI is connected, I mocked the GUI class to provide a settable connected attribute. Interested in any opinions on this approach.

This also removes the concept of a "Mark II" from the test as it should be any device with a connected display.