Closed forslund closed 2 years ago
Voight Kampff Integration Test Succeeded (Results)
Merging #3030 (9d2746a) into dev (ea15759) will increase coverage by
0.01%
. The diff coverage is65.00%
.:exclamation: Current head 9d2746a differs from pull request most recent head b0f9a10. Consider uploading reports for the commit b0f9a10 to get more accurate results
@@ Coverage Diff @@
## dev #3030 +/- ##
==========================================
+ Coverage 53.04% 53.06% +0.01%
==========================================
Files 123 123
Lines 11170 11187 +17
==========================================
+ Hits 5925 5936 +11
- Misses 5245 5251 +6
Impacted Files | Coverage Δ | |
---|---|---|
mycroft/client/enclosure/base.py | 0.00% <0.00%> (ø) |
|
mycroft/tts/espeak_tts.py | 70.27% <72.22%> (+0.27%) |
:arrow_up: |
mycroft/tts/tts.py | 79.27% <0.00%> (-0.33%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ea15759...b0f9a10. Read the comment docs.
Description
This uses shellcheck directives instead of excludes only available in CICD as suggested by @PureTryOut.
This leaves SC1090/1091 as a general excludes, these are set in the .shellcheckrc to make sure the developer gets the same checks as the CI does.
How to test
Ensure the CICD approves.
Contributor license agreement signed?
CLA [ Yes ]