Closed krisgesling closed 2 years ago
Voight Kampff Integration Test Succeeded (Results)
Merging #3031 (40b9cb8) into dev (dd7f7ab) will increase coverage by
0.00%
. The diff coverage is81.81%
.:exclamation: Current head 40b9cb8 differs from pull request most recent head 2699a24. Consider uploading reports for the commit 2699a24 to get more accurate results
@@ Coverage Diff @@
## dev #3031 +/- ##
=======================================
Coverage 53.49% 53.49%
=======================================
Files 121 121
Lines 11084 11090 +6
=======================================
+ Hits 5929 5933 +4
- Misses 5155 5157 +2
Impacted Files | Coverage Δ | |
---|---|---|
mycroft/stt/__init__.py | 57.18% <66.66%> (+0.09%) |
:arrow_up: |
mycroft/tts/tts.py | 79.41% <66.66%> (-0.13%) |
:arrow_down: |
mycroft/configuration/config.py | 75.15% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dd7f7ab...2699a24. Read the comment docs.
Hello @krisgesling! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Given this was really me reviewing and porting another PR, I'm going to merge it.
Description
The inflection dependency was being used for a single string operation that is easily replaced by a string operation.
Thanks to @JarbasAI for this one.
How to test
Remote settings should continue to work as usual.
Contributor license agreement signed?