search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.49k stars 1.27k forks source link

Add Dilmanc TTS #3032

Closed saymantech-co closed 2 years ago

saymantech-co commented 2 years ago

Description

Add Dilmanc TTS support. A tts for az-az lang.

config sample: "dilmanc": { "url": "http://dilmanc.az/en/text-to-speech", // speed range: 0.4 - 2.5, default: 0.95 "speed": 0.95, "lang": "az-az" }

Contributor license agreement signed?

pep8speaks commented 2 years ago

Hello @saymantech-co! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-11-09 09:38:24 UTC
devops-mycroft commented 2 years ago

Voight Kampff Integration Test Succeeded (Results)

krisgesling commented 2 years ago

Hey there - this looks great - thanks!

We've recently added a plugin system so that TTS services like this can exist independently of Mycroft-core as an independent Python package. This keeps core lighter, and means you don't need to wait on mycroft-core to implement improvements or bug fixes.

In terms of the code, the shift is pretty minimal. We've got some documentation about the new system here: https://mycroft-ai.gitbook.io/docs/mycroft-technologies/mycroft-core/plugins

and if you have any trouble getting it to work please shout out.

In the meantime I'm going to close this PR, but feel free to ask questions here or in Chat.