MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.49k stars 1.27k forks source link

Fix config priority #3033

Closed forslund closed 2 years ago

forslund commented 2 years ago

Description

This resolves #3029 as well as a bug masking the issue by not loading remote config at startup.

How to test

Contributor license agreement signed?

CLA [ Yes ]

codecov-commenter commented 2 years ago

Codecov Report

Merging #3033 (b566a55) into dev (ef56d71) will increase coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head b566a55 differs from pull request most recent head 70df575. Consider uploading reports for the commit 70df575 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3033      +/-   ##
==========================================
+ Coverage   53.07%   53.08%   +0.01%     
==========================================
  Files         123      123              
  Lines       11187    11187              
==========================================
+ Hits         5937     5939       +2     
+ Misses       5250     5248       -2     
Impacted Files Coverage Δ
mycroft/configuration/config.py 73.64% <100.00%> (+1.35%) :arrow_up:
mycroft/util/log.py 91.22% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef56d71...70df575. Read the comment docs.

devops-mycroft commented 2 years ago

Voight Kampff Integration Test Succeeded (Results)