MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.49k stars 1.27k forks source link

Remove incorrectly added args in GUIWebsocketHandler methods #3036

Closed krisgesling closed 2 years ago

krisgesling commented 2 years ago

Description

PR #2879 updated the websocket-client and changed function signatures to account for API changes in that package. The instances in this PR were falsely changed as the GUI bus does not use the websocket-client.

Consistency would be good however modifying these for the GUI bus would require significant work. For now we have two slightly different bus interfaces.

This was causing the GUI to crash on click events and on close.

Thanks to @AIIX for help getting to the right answer on this one!

How to test

Test 1:

Test 2:

Contributor license agreement signed?

devops-mycroft commented 2 years ago

Voight Kampff Integration Test Succeeded (Results)

krisgesling commented 2 years ago

Failure seems like it was a brief outage in the DLF radio station. Working locally now so retrying.

AIIX commented 2 years ago

Fixes the crash, please merge!

krisgesling commented 2 years ago

@AIIX - can you give the PR an approving review? Then I can merge it in.