Closed krisgesling closed 2 years ago
Voight Kampff Integration Test Succeeded (Results)
Failure seems like it was a brief outage in the DLF radio station. Working locally now so retrying.
Fixes the crash, please merge!
@AIIX - can you give the PR an approving review? Then I can merge it in.
Description
PR #2879 updated the websocket-client and changed function signatures to account for API changes in that package. The instances in this PR were falsely changed as the GUI bus does not use the websocket-client.
Consistency would be good however modifying these for the GUI bus would require significant work. For now we have two slightly different bus interfaces.
This was causing the GUI to crash on click events and on close.
Thanks to @AIIX for help getting to the right answer on this one!
How to test
Test 1:
TypeError: on_close() missing 1 required positional argument: '_'
Test 2:
Contributor license agreement signed?