Do not create identity folder when trying to read the identity file

[forslund]

Description

This is a followup PR on #3045 ensuring that the identity2.json isn't created until the file is actually written. This is not as big an issue as the things handled in the previous PR since the access is generally locked using the ComboLock but this makes it less surprising to see the new folder.

How to test

• remove the .config/mycroft folder
• start up mycroft
• let the pairing process start and check that the .config/mycroft/identity folder hasn't been created.
• Finish the pairing
• Check that the folder and identity2.json exists
• Ask mycroft about the weather and ensure it is fetched correctly

Contributor license agreement signed?

CLA [ Yes ]

[devops-mycroft]

Voight Kampff Integration Test Succeeded (Results)

[codecov-commenter]

Codecov Report

Merging #3047 (4dd3dd3) into dev (ae99974) will decrease coverage by 0.02%. The diff coverage is 42.85%.

@@            Coverage Diff             @@
##              dev    #3047      +/-   ##
==========================================
- Coverage   53.11%   53.08%   -0.03%     
==========================================
  Files         123      123              
  Lines       11188    11192       +4     
==========================================
- Hits         5942     5941       -1     
- Misses       5246     5251       +5     

Impacted Files	Coverage Δ
mycroft/identity/__init__.py	60.52% <42.85%> (-3.37%)	:arrow_down:
mycroft/filesystem/__init__.py	76.00% <0.00%> (-4.00%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ae99974...4dd3dd3. Read the comment docs.