search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.49k stars 1.27k forks source link

Correct incidental findings from review of dev_setup.sh #3052

Closed mikejgray closed 2 years ago

mikejgray commented 2 years ago

Description

Corrects incidental findings from review of dev_setup.sh (fixes #1714). Please let me know if you'd like adjustments to be made - this is an old issue so I hope this PR is still timely!

How to test

Execute dev_setup.sh in various operating systems

Contributor license agreement signed?

CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement

krisgesling commented 2 years ago

Hey Mike, thanks for this - there's some great stuff here!

Just wanted to flag PR #3048 as there's a bit of overlap but definitely a common goal :+1:

mikejgray commented 2 years ago

Hey Mike, thanks for this - there's some great stuff here!

Just wanted to flag PR #3048 as there's a bit of overlap but definitely a common goal 👍

Ah, hadn't noticed - how do you want to proceed? I don't want to collide with the work you've already done, so please let me know.

mikejgray commented 2 years ago

Hey @krisgesling is this still relevant/helpful? I'm happy to refactor or close the PR if not.

mikejgray commented 2 years ago

Thanks Kris - I'll break this up into multiple PRs, especially since it's so stale now.

mikejgray commented 2 years ago

One PR is more than sufficient for the changes. Here it is: https://github.com/MycroftAI/mycroft-core/pull/3105