search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.49k stars 1.27k forks source link

Add `supported_languages` parameter to STT and TTS base classes #3059

Closed NeonDaniel closed 2 years ago

NeonDaniel commented 2 years ago

Description

This PR adds a property to the base STT and TTS classes that a plugin can override to specify what languages it supports.

3058

How to test

This change should not affect behavior. The added property should always return set() currently.

Contributor license agreement signed?

CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement

codecov-commenter commented 2 years ago

Codecov Report

Merging #3059 (42541a6) into dev (3d963ce) will increase coverage by 0.00%. The diff coverage is 66.66%.

:exclamation: Current head 42541a6 differs from pull request most recent head 01cc852. Consider uploading reports for the commit 01cc852 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3059   +/-   ##
=======================================
  Coverage   53.08%   53.08%           
=======================================
  Files         123      123           
  Lines       11192    11198    +6     
=======================================
+ Hits         5941     5945    +4     
- Misses       5251     5253    +2
Impacted Files Coverage Δ
mycroft/stt/__init__.py 57.18% <66.66%> (+0.09%) :arrow_up:
mycroft/tts/tts.py 79.47% <66.66%> (-0.13%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d963ce...01cc852. Read the comment docs.

devs-mycroft commented 2 years ago

Hello, @NeonDaniel, thank you for helping with the Mycroft project! We welcome everyone into the community and greatly appreciate your help as we work to build an AI for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require a Contributor Licensing Agreement (CLA) before accepting any code contribution. This agreement makes it crystal clear that along with your code you are offering a license to use it within the confines of this project. You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank you!

NeonDaniel commented 2 years ago

Failing unit tests appear to be unrelated to the changes in this PR. Are there any changes needed on my end?

devops-mycroft commented 2 years ago

Voight Kampff Integration Test Succeeded (Results)