MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.49k stars 1.27k forks source link

Add initial value for shell variable #3061

Closed luca-vercelli closed 2 years ago

luca-vercelli commented 2 years ago

Condition

if [ $disable_precise_later == true ]; 

gives a syntax error if variable is not initialized

Contributor license agreement signed?

Yes

forslund commented 2 years ago

This definitely seems like the correct thing to do.

I think #3060 fixes the same issue (in a different way) should both of these fixes be merged...both initializing the value and using double brackets?

Edit: Shellcheck is ok with either solution so no need to change anything

krisgesling commented 2 years ago

Thanks Luca!

I'm just retriggering fresh builds - I think we're all clear at the moment so should be able to merge this shortly.

devops-mycroft commented 2 years ago

Voight Kampff Integration Test Succeeded (Results)