Closed TheRealDGD closed 2 years ago
Hello @TheRealDGD! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Hello, @TheRealDGD, thank you for helping with the Mycroft project! We welcome everyone into the community and greatly appreciate your help as we work to build an AI for Everyone.
To protect yourself, the project, and users of Mycroft technologies we require a Contributor Licensing Agreement (CLA) before accepting any code contribution. This agreement makes it crystal clear that along with your code you are offering a license to use it within the confines of this project. You retain ownership of the code, this is just a license.
Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank you!
Hello,
I already signed the CLA. Are there additional steps needed after signing?
mycroft-developers @.***> schrieb am Sa. 12. Feb. 2022 um 12:18:
Hello, @TheRealDGD https://github.com/TheRealDGD, thank you for helping with the Mycroft project! We welcome everyone into the community and greatly appreciate your help as we work to build an AI for Everyone.
To protect yourself, the project, and users of Mycroft technologies we require a Contributor Licensing Agreement (CLA) before accepting any code contribution. This agreement makes it crystal clear that along with your code you are offering a license to use it within the confines of this project. You retain ownership of the code, this is just a license.
Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank you!
— Reply to this email directly, view it on GitHub https://github.com/MycroftAI/mycroft-core/pull/3071#issuecomment-1037152368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXXH5VFI4P3ZUEFLDH2GWIDU2Y62BANCNFSM5OFZ2JQQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
Hi, the CLA has a manual step where your git username is added to https://github.com/MycroftAI/contributors, @krisgesling usually handles this. If you signed the CLA recently give it a couple of days. If it was a bit ago hopefully gez will see the mention here or we'll ping him again.
CLA received - thanks!
Just FYI - the tests are borked from a Python 3.6 issue unrelated to this PR. Hopefully will have that sorted today.
Voight Kampff Integration Test Succeeded (Results)
Excellent, thanks DGD!
Description
Added duration_to_bytes to fix AttributeError: 'FileMockMicrophone' object has no attribute 'duration_to_bytes' in call from mycroft-core/mycroft/client/speech/mic.py _wait_until_wake_word
How to test
./start-mycroft.sh wakewordtest
Contributor license agreement signed?
CLA [X] (Whether you have signed a CLA - Contributor Licensing Agreement