Closed krisgesling closed 2 years ago
Can't believe I missed it in PR #3073 - but we were grabbing the Python3.6 pip in both branches of the conditional.
Surprising that all the tests were passing still.
Voight Kampff Integration Test Succeeded (Results)
Merging #3080 (909d89e) into dev (8ee3e8d) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## dev #3080 +/- ##
=======================================
Coverage 53.13% 53.13%
=======================================
Files 122 122
Lines 11159 11159
=======================================
Hits 5929 5929
Misses 5230 5230
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8ee3e8d...909d89e. Read the comment docs.
Doh!
I assume this worked since python >=3.7 is backwards compatible with older pip code.
It was meant to be
if "${VIRTUALENV_ROOT}/bin/${opt_python}" --version | grep " 3.6" > /dev/null; then
so the output isn't printed.
Best get this in and hide my copy pasta :). The /dev/null fix can be done separately, it's more important that this works as intended.
Description
Fixes the url to fetch pip from on versions of Python > 3.6
How to test
Ensure all Github Actions complete showing it installs correctly.
Contributor license agreement signed?