MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.48k stars 1.27k forks source link

bash dev_setup.sh --clean does not remove skills symlink #3084

Closed trammell closed 2 years ago

trammell commented 2 years ago

Describe the bug --clean option is advertised as "Remove files and folders created by this script"

To Reproduce

Following the instructions at https://mycroft-ai.gitbook.io/docs/using-mycroft-ai/get-mycroft/linux#installing-via-git-clone:

  1. bash dev_setup.sh
  2. bash dev_setup.sh --clean
  3. ls -l

Expected behavior skills symlink should not be present

Environment (please complete the following information):

Additional context Just a newbie trying to get Mycroft working.

krisgesling commented 2 years ago

Hey there, thanks for logging this.

I'd agree - it's a symlink created by the script so it should get removed.