search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.48k stars 1.27k forks source link

Remove skills dir symlink on --clean #3086

Closed krisgesling closed 2 years ago

krisgesling commented 2 years ago

Description

Delete the skills symlink when dev_setup.sh --clean is executed.

Added note regarding files that won't be cleaned - this is anything in the mycroft-core directory eg mimic and .installed. However I still think it's worth removing the skills symlink as the target directory no longer exists.

Fixes #3084

How to test

run --clean and the skills directory symlink should be removed

Contributor license agreement signed?

devops-mycroft commented 2 years ago

Voight Kampff Integration Test Succeeded (Results)

codecov-commenter commented 2 years ago

Codecov Report

Merging #3086 (a2ffe65) into dev (5f4c68e) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3086   +/-   ##
=======================================
  Coverage   53.58%   53.58%           
=======================================
  Files         121      121           
  Lines       11128    11128           
=======================================
  Hits         5963     5963           
  Misses       5165     5165

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f4c68e...a2ffe65. Read the comment docs.