search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.48k stars 1.27k forks source link

Fix inconsistent hotwords configuration reference #3088

Closed fsa317 closed 2 years ago

fsa317 commented 2 years ago

Description

Fixes Issue-3006 by correctly looking up phoneme_duration setting

How to test

Set hotwords.{myword}.phoneme_duration to a larger value than 120 and see the recording of the wake word change length

Contributor license agreement signed?

CLA [ x] (Whether you have signed a CLA - Contributor Licensing Agreement

devops-mycroft commented 2 years ago

Hello, @fsa317, thank you for helping with the Mycroft project! We welcome everyone into the community and greatly appreciate your help as we work to build an AI for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require a Contributor Licensing Agreement (CLA) before accepting any code contribution. This agreement makes it crystal clear that along with your code you are offering a license to use it within the confines of this project. You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank you!

devops-mycroft commented 2 years ago

Voight Kampff Integration Test Succeeded (Results)

krisgesling commented 2 years ago

lol the height of the Eiffel tower literally changed...

Edit: to be clear - this test failure isn't related to your PR. I'll get it fixed up.