MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.48k stars 1.27k forks source link

Add pipewire check for Arch #3091

Closed khionu closed 2 years ago

khionu commented 2 years ago

Description

Fixes #2980 by running pacman -Qs to verify installation of pulseaudio -> pipewire compat layer.

How to test

Run installation on Arch Linux install with and without pipewire-pulse, the script will print the list of packages being installed. pulseaudio and pulseaudio-alma should only exist when pipewire-pulse is not installed.

Contributor license agreement signed?

CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement

devops-mycroft commented 2 years ago

Hello, @khionu, thank you for helping with the Mycroft project! We welcome everyone into the community and greatly appreciate your help as we work to build an AI for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require a Contributor Licensing Agreement (CLA) before accepting any code contribution. This agreement makes it crystal clear that along with your code you are offering a license to use it within the confines of this project. You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank you!

khionu commented 2 years ago

I did sign it very shortly before opening the PR, maybe too shortly?

devops-mycroft commented 2 years ago

Voight Kampff Integration Test Succeeded (Results)

krisgesling commented 2 years ago

Hey there, thanks for contributing!

There's a manual step in reviewing the signed CLA's to ensure they contain valid information. But it all looks good and you've been added to our list of excellent humans (and other sentient beings)!

codecov-commenter commented 2 years ago

Codecov Report

Merging #3091 (df33c69) into dev (ccd577b) will not change coverage. The diff coverage is n/a.

:exclamation: Current head df33c69 differs from pull request most recent head d0a64bb. Consider uploading reports for the commit d0a64bb to get more accurate results

@@           Coverage Diff           @@
##              dev    #3091   +/-   ##
=======================================
  Coverage   53.58%   53.58%           
=======================================
  Files         121      121           
  Lines       11128    11128           
=======================================
  Hits         5963     5963           
  Misses       5165     5165           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ccd577b...d0a64bb. Read the comment docs.