search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.48k stars 1.27k forks source link

dev_setup: Give packages in separate args to pacman #3094

Closed forslund closed 2 years ago

forslund commented 2 years ago

Description

This makes sure the packages aren't clumped together into a single argument when using pacman to install packages for arch linux. Perhaps pacman handles this correctly (apt does not) but generally it's better to use an array instead of a string when sending arguments.

Contributor license agreement signed?

CLA [ x ]

codecov-commenter commented 2 years ago

Codecov Report

Merging #3094 (f9faad6) into dev (28d512e) will not change coverage. The diff coverage is n/a.

:exclamation: Current head f9faad6 differs from pull request most recent head 1b0034b. Consider uploading reports for the commit 1b0034b to get more accurate results

@@           Coverage Diff           @@
##              dev    #3094   +/-   ##
=======================================
  Coverage   53.58%   53.58%           
=======================================
  Files         121      121           
  Lines       11128    11128           
=======================================
  Hits         5963     5963           
  Misses       5165     5165

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 28d512e...1b0034b. Read the comment docs.

devops-mycroft commented 2 years ago

Voight Kampff Integration Test Succeeded (Results)

krisgesling commented 2 years ago

Yeah nice - @khionu can you test this one and confirm it works for you?