search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.51k stars 1.27k forks source link

Remove the chromecast audio backend #3097

Closed forslund closed 2 years ago

forslund commented 2 years ago

Description

The pychromecast module is quite outdated and I think the backend would fit better as a plugin now.

The chromecast backend was one of the first proof-of-concept remote backends but due to time limits it's use hasn't been explored in any detail and it's a bit outdated at the moment.

How to test

Ensure the normal audio services load as expected.

Contributor license agreement signed?

CLA [ x ] (Whether you have signed a CLA - Contributor Licensing Agreement

devops-mycroft commented 2 years ago

Voight Kampff Integration Test Succeeded (Results)

JarbasAl commented 2 years ago

i saw chromecast mentioned as a nice surprise a couple times, but mostly as a source of confusion for new users, i haven't ever seen anyone mention explicitly using/configuring it

i was hoping this PR would happen so i didn't have to make a ovos plugin for compat, glad i kept putting it off :D

j1nx commented 2 years ago

Perhaps remove it from the extra backend requirements file as well; https://github.com/MycroftAI/mycroft-core/blob/dev/requirements/extra-audiobackend.txt#L1

forslund commented 2 years ago

@j1nx totally true! Will fix