pep8speaks
commented
2 years ago Hello @ken-mycroft! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
- In the file
mycroft/enclosure/hardware/MycroftFan/fan_sj201r5.py:
Line 7:1: E302 expected 2 blank lines, found 1 Line 20:26: E231 missing whitespace after ',' Line 21:38: E231 missing whitespace after ',' Line 21:80: E501 line too long (84 > 79 characters) Line 22:80: E501 line too long (82 > 79 characters) Line 22:83: W291 trailing whitespace Line 50:22: E201 whitespace after '(' Line 50:44: E202 whitespace before ')' Line 53:20: E201 whitespace after '(' Line 53:27: E201 whitespace after '(' Line 53:43: E202 whitespace before ')' Line 53:45: E202 whitespace before ')' Line 56:80: E501 line too long (93 > 79 characters) Line 69:1: W391 blank line at end of file
- In the file
mycroft/enclosure/hardware/MycroftLed/led_sj201r5.py:
Line 20:1: E302 expected 2 blank lines, found 1 Line 62:80: E501 line too long (85 > 79 characters) Line 79:80: E501 line too long (82 > 79 characters) Line 83:5: E303 too many blank lines (2)
Description
Adds support for the sj201r5 board. this device reverts to neopixels for LEDs and pwm GPIO for fan.
How to test
Install an sj201r5 board. Change the config file board type to sj201r5
Contributor license agreement signed?
CLA [Y ]