MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.51k stars 1.27k forks source link

add german noise-word-list #3122

Closed pfefferle closed 2 years ago

pfefferle commented 2 years ago

Description

It adds the german noise words, as discussed here: https://github.com/MycroftAI/mycroft-core/issues/3050

You can find the noise word discussion here: https://openvoice-tech.net/index.php?title=Mycroft_in_German

Contributor license agreement signed?

CLA [X] (Whether you have signed a CLA - Contributor Licensing Agreement

devops-mycroft commented 2 years ago

Voight Kampff Integration Test Failed (Results). Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

codecov-commenter commented 2 years ago

Codecov Report

Merging #3122 (340e301) into dev (1b67bf3) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 340e301 differs from pull request most recent head 4e869f3. Consider uploading reports for the commit 4e869f3 to get more accurate results

@@           Coverage Diff           @@
##              dev    #3122   +/-   ##
=======================================
  Coverage   54.05%   54.05%           
=======================================
  Files         120      120           
  Lines       11032    11032           
=======================================
  Hits         5963     5963           
  Misses       5069     5069           

Help us with your feedback. Take ten seconds to tell us how you rate us.

pfefferle commented 2 years ago

@krisgesling "wo" (german for "where") is in the list, might that cause the issue? because it seems to be a problem with skills that have intents like "where is...". But the eng noise list also includes "where"...

krisgesling commented 2 years ago

It shouldn't cause a problem because we don't actually test on other languages at the moment. So really this change shouldn't change the test outcomes at all.

At least locally the Wikipedia Skill replies "Amerstand is the capital and most populist... " But the speak output I can see in the logs for these tests is just "Amsterdam , lit."

This is likely going to need some deeper investigation as to what's going on since we aren't seeing the same thing without this PR.

forslund commented 2 years ago

@krisgesling The wiki-skill in the mycroft-skills repo seem to be outdated. The issue occurs in the current version but not in the latest. so maybe an update is in order?

krisgesling commented 2 years ago

Ah the Wiki Skill seems to be blocked until we release a new version of core. See: https://github.com/MycroftAI/mycroft-skills/pull/1563

Unfortunately that's not something we're we're going to get to before the Mark II ships next month sorry.

pfefferle commented 2 years ago

I saw that the french version was merged, any news for the German version? https://github.com/MycroftAI/mycroft-core/pull/3128

krisgesling commented 2 years ago

Yes, thanks for the nudge! The test issue is unrelated so I figured we should merge these in.