MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.48k stars 1.27k forks source link

The start/end_listening sounds should be called with the pulse media.role=phone to enable ducking #3148

Open Ramblurr opened 1 year ago

Ramblurr commented 1 year ago

Describe the bug

When pulse ducking is enabled, the background audio is only ducked when TTS audio is played. But I think the start and end listening sounds should also be ducked

To Reproduce Steps to reproduce the behavior:

  1. Enable ducking
  2. Say "Hey Mycroft.."

Result: The start_listening sound is played, but the existing background music/audio is not ducked.

Expected behavior

Play the start/end_listening audio files with the proper pulse audio environment to enable ducking (media.role=phone)

Log files If possible, add log files from /var/log/mycroft/ to help explain your problem.

You may also include screenshots, however screenshots of log files are often difficult to read and parse.

If you are running Mycroft, the Support Skill helps to automate gathering this information. Simply say "Create a support ticket" and the Skill will put together a support package and email it to you.

Environment (please complete the following information):

krisgesling commented 1 year ago

I did not know this existed. Nice suggestion!

forslund commented 1 year ago

That's a good idea. I wonder if we should create a helper function, play_audio_and_duck() (or something) to streamline the experience a bit compared to creating the environment at each call site.