search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.51k stars 1.27k forks source link

Fails if python3 is default #360

Closed ParkerMc closed 7 years ago

ParkerMc commented 8 years ago

In arch python 3 is default you can easy make this change my changing any thing like python file name here to python file name here and pip install to pip2 install this should work on all systems and in the arch install file change stuff like sudo pacman -S python-pip to sudo pacman -S python2-pip if you need me to test any thing let me know.

aatchison commented 8 years ago

Thanks https://github.com/MycroftAI/mycroft-core/blob/master/dev_setup.sh Do you think we could check in the dev_setup.sh ? The virtual env should install python 2.7 right? I added a flag for that. Are you saying that we should replace pip with pip2 in that script ? Feel free to edit the arch build setup script if you like.

ParkerMc commented 8 years ago

Sorry I guess I have not been clear. But now I see how the part I was confused by works. Would you like me to just make the changes and make a pull request?

aatchison commented 8 years ago

Sure, make as many PRs as you like. I don't currently run arch on any of my machines, so I wouldn't be able to test that.

ParkerMc commented 7 years ago

Fixed with #359 sorry I did not think it would auto add the new commits to the pull request.