aatchison
commented
8 years ago Interesting. We didn't account for those that might have their own virtualenvs set up.
On Oct 10, 2016 7:30 PM, "Nicolas Couture" notifications@github.com wrote:
Working with a shell configured to use virtualenv via virtualenvwrapper may result in the creation of a new virtualenv root directory.
For example if WORKON_HOME is set to $HOME/projects, executing dev_setup.sh will create the $HOME/.virtualenv and use it as the location for the "mycroft" virtual environment.
Since virtualenv's documentation does not describe the use of the VIRTUALENV_ROOT variable, I would like to suggest evaluating if WORKON_HOME is not empty before using VIRTUALENV_ROOT, in which case its value becomes used over VIRTUALENV_ROOT's default.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MycroftAI/mycroft-core/issues/372, or mute the thread https://github.com/notifications/unsubscribe-auth/AIJOO5kEByV4lBh9mESW0dIp0Cq23Mcyks5qyti_gaJpZM4KTH32 .
ncouture
Working with a shell configured to use virtualenv via virtualenvwrapper may result in the creation of a new virtualenv root directory.
For example if WORKON_HOME is set to $HOME/projects, executing dev_setup.sh will create the $HOME/.virtualenv and use it as the location for the "mycroft" virtual environment.
Since virtualenv's documentation does not describe the use of the VIRTUALENV_ROOT variable, I would like to suggest evaluating if WORKON_HOME is not empty before using VIRTUALENV_ROOT, in which case its value becomes used over VIRTUALENV_ROOT's default.