search

MycroftAI / mycroft-core

Mycroft Core, the Mycroft Artificial Intelligence platform.
https://mycroft.ai
Apache License 2.0
6.52k stars 1.27k forks source link

During Pairing Prompt, Mycroft should read URL with "dot" where periods are present #58

Closed ryanleesipes closed 8 years ago

ryanleesipes commented 8 years ago

During Pairing Prompt, Mycroft should read URL with "dot" where periods are present. Currently he just does a break between the different parts of the URL and also does not read "ai" as "A, I" as he should.

ryanleesipes commented 8 years ago

@jdorleans, @clusterfudge I can't find in the code where it reads out "cerberus.mycroft.ai" - can you point me at the right place?

Cliabhach commented 8 years ago

@ryanleesipes I think that would be https://github.com/MycroftAI/mycroft-core/blob/master/mycroft/skills/cerberus_config/__init__.py#L41 , https://github.com/MycroftAI/mycroft-core/blob/bdcd8582aa4938102a90d73bc389f10b272975da/mycroft/skills/weather/__init__.py#L135 , possibly elsewhere.

Those emit a message that the speech file picks up in https://github.com/MycroftAI/mycroft-core/blob/master/mycroft/client/speech/main.py#L59 , which in turn passes it off to the execute method on a tts from https://github.com/MycroftAI/mycroft-core/tree/master/mycroft/tts

ryanleesipes commented 8 years ago

Giving this to @jdorleans

MatthewScholefield commented 8 years ago

Should anything with a period and no space be read as "dot"? For instance, what about right before speaking with mimic, regex replace "([^,. ]).([^,. ])" with "$1 dot $2"?

ryanleesipes commented 8 years ago

@Wolfgange3311999 yes, I think that would be good.

ryanleesipes commented 8 years ago

@Wolfgange3311999 do you have any idea of how to make this happen? If so I can reassign this to you.

jdorleans commented 8 years ago

Guys, let's not change that behaviour in mimic. The char . must be a real pause, that's the way it is on a natural language. That said, there is a simpler way of solving that problem. I'll fix that.

Cliabhach commented 8 years ago

@jdorleans: we should probably add something to the docs about when to use phonetic spelling (like 'dot') in spoken text.

jdorleans commented 8 years ago

@Cliabhach you're right. We do still have much information to add on our docs and some of them are not very easy to identify until they appear as an issue. I'll take care of some of them and add on our docs.

ryanleesipes commented 8 years ago

91 has been Merged, closing this issue. However, I do think we may want to move to using "dot" in Mimic for instances when there aren't spaces between words/numbers on both sides of a period.