MycroftAI / mycroft-dinkum

A consumer ready version of Mycroft specifically for the Mark II.
Apache License 2.0
20 stars 8 forks source link

Fixing both the image problem and removing unnecessary lines that mig… #23

Closed alan-mycroft closed 2 years ago

alan-mycroft commented 2 years ago

…ht in some circumstances cause problems.

Description

I introduced a bug last time I touched the code that decides what image to show. It made it so that if a genre should have a generic image, instead of showing that image it would use the previous non-generic image. That is fixed.

The code was also needlessly running an initial search, which in the current master branch might be responsible for some flakey behavior. That is also removed.

Finally, removed an unneeded log line.

Type of PR

If your PR fits more than one category, there is a high chance you should submit more than one PR. Please consider this carefully before opening the PR. Either delete those that do not apply, or add an x between the square brackets like so: - [x]

Testing

"Play rock" "Play talk radio" shows generic image rather than the rock one