search

MycroftAI / mycroft-gui

The Graphical User Interface used by the Mycroft Mark II and more
Apache License 2.0
165 stars 57 forks source link

Mycroft config on dev install #106

Open krisgesling opened 2 years ago

krisgesling commented 2 years ago

I just noticed that we're setting the enclosure.platform config to mycroft_mark_2 on install.

Is that to get around people using if platform == "mycroft_mark_2" in Skills etc, when they want to check if a GUI is connected? Or are there other reasons a dev environment should pretend to be a Mark 2?

I can certainly see having a "Mark II" mode being useful - to try and emulate a Mark II setup as much as possible - config, correct dimensions, etc. But I'm wondering if that should be an intentional option rather than the default config?

It jumped out at me because if we are writing to a mycroft.conf file we'll need to switch to the XDG path for it instead of the hard coded value.

Any thoughts or preferences?

AIIX commented 2 years ago

Will add the configuration for platform to the dev_script.sh, the hardcoded path is in /etc/mycroft its at system level, so if mycroft-core does adopt xdg even at system level config, we can then switch to /etc/xdg/